Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/couchdb] Pass pointer to ScrapeErrors instead of by value #13011

Merged
merged 5 commits into from
Aug 9, 2022
Merged

[receiver/couchdb] Pass pointer to ScrapeErrors instead of by value #13011

merged 5 commits into from
Aug 9, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

@BinaryFissionGames BinaryFissionGames commented Aug 8, 2022 •
edited
Loading

Description:

  • fixes issue where partial errors are not recorded due to passing the ScrapeErrors struct by value
  • rename errors -> errs to avoid possible shadowing of the errors package

Link to tracking Issue: #13007

Testing:

  • Added a new test to assert that the returned PartialError increments the number of recorded errors.

Documentation: N/A

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review August 8, 2022 17:45
@djaglowski djaglowski merged commit 8ad1dcb into open-telemetry:main Aug 9, 2022
@BinaryFissionGames BinaryFissionGames mentioned this pull request Aug 9, 2022
Closed
@BinaryFissionGames BinaryFissionGames deleted the couchdbreceiver/fix-scrape-errors branch August 9, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@cpheps cpheps cpheps approved these changes

Assignees

@Aneurysm9 Aneurysm9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BinaryFissionGames @djaglowski @cpheps @Aneurysm9