Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/hostmetrics] Add new process metrics #12972

Merged
merged 1 commit into from
Nov 2, 2022
Merged

[receiver/hostmetrics] Add new process metrics #12972

merged 1 commit into from
Nov 2, 2022

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Aug 4, 2022 •
edited
Loading

Description:

Add the following process metrics:

  • process.context_switches
  • process.open_file_descriptors

Link to tracking Issue:#12482

Spec PR to add semantic conventions for the added metrics: open-telemetry/opentelemetry-specification#2706

Testing:

Unit tests and manual testing of the metrics.

@evan-bradley evan-bradley requested a review from a team August 4, 2022 20:41
@dmitryax
Copy link
Member

dmitryax commented Aug 4, 2022

@evan-bradley did you submit a spec PR for adding semantic conventions for these metrics?

@evan-bradley
Copy link
Contributor Author

I opened the following spec PR to add these metrics to the semantic conventions: open-telemetry/opentelemetry-specification#2706

@dmitryax
Copy link
Member

dmitryax commented Aug 4, 2022

I opened the following spec PR to add these metrics to the semantic conventions: open-telemetry/opentelemetry-specification#2706

Thanks! Let's make sure that PR is merged first

@evan-bradley evan-bradley force-pushed the issue-12482 branch 2 times, most recently from c30c79b to 1a93fb8 Compare August 5, 2022 14:03
@evan-bradley evan-bradley mentioned this pull request Aug 18, 2022
Closed
6 tasks
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 20, 2022
@evan-bradley
Copy link
Contributor Author

This is currently waiting on open-telemetry/opentelemetry-specification#2726 to be resolved to determine which direction to take with open-telemetry/opentelemetry-specification#2706. I will update this PR as soon as the semantic conventions PR has been merged.

@github-actions github-actions bot removed the Stale label Aug 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 7, 2022
@github-actions github-actions bot removed the Stale label Sep 10, 2022
@evan-bradley evan-bradley mentioned this pull request Sep 13, 2022
Closed
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Sep 28, 2022
@evan-bradley evan-bradley force-pushed the issue-12482 branch 2 times, most recently from 0645b27 to ba57ec3 Compare September 29, 2022 17:50
@github-actions github-actions bot removed the Stale label Sep 30, 2022
@evan-bradley
Copy link
Contributor Author

evan-bradley commented Sep 30, 2022 •
edited
Loading

@dmitryax Please take a look. The PR for the semantic conventions for these metrics has been merged, though it is not yet released.

@evan-bradley
Copy link
Contributor Author

@dmitryax These metrics have been included in the semantic conventions in version 1.14.0 of the specification.

@evan-bradley evan-bradley force-pushed the issue-12482 branch 2 times, most recently from 71c84a8 to 637ada7 Compare October 18, 2022 18:33
@evan-bradley
Copy link
Contributor Author

@dmitryax Please take a look. The new metrics are part of the semantic conventions, and the PR has been rebased.

@dmitryax
Copy link
Member

Need #15274 to pass CI

@evan-bradley
[receiver/hostmetrics] Add new process metrics
567a28c 
Add the following process metrics:
- `process.context_switches`
- `process.open_file_descriptors`
@andrzej-stencel
Copy link
Member

Can this be merged @dmitryax?

@dmitryax dmitryax merged commit e9099f1 into open-telemetry:main Nov 2, 2022
dineshg13 pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Nov 21, 2022
@evan-bradley @dineshg13
[receiver/hostmetrics] Add new process metrics (open-telemetry#12972)
dc46043 
Add the following process metrics:
- `process.context_switches`
- `process.open_file_descriptors`

Co-authored-by: Evan Bradley <[email protected]>
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
@evan-bradley @shalper2
[receiver/hostmetrics] Add new process metrics (open-telemetry#12972)
d331a39 
Add the following process metrics:
- `process.context_switches`
- `process.open_file_descriptors`

Co-authored-by: Evan Bradley <[email protected]>
@andrzej-stencel andrzej-stencel mentioned this pull request Jan 26, 2023
Merged
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@dmitryax dmitryax dmitryax approved these changes

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evan-bradley @dmitryax @andrzej-stencel @bogdandrutu @jpkrohling