Correctly enable caching of go mods on windows #12923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Aug 3, 2022
djaglowski
approved these changes
Aug 4, 2022
codeboten
approved these changes
Aug 4, 2022
|
Looks like you need to rebase |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
bogdandrutu
force-pushed
the
windowscache
branch
2 times, most recently
from
a066029
to
dd1ea02
Compare
The current cache has a race condition and last executed job in the matrix most likely will save that cache since it has same name for all executions. * Add a setup job that downloads all go mod deps and caches them. * Add a per matrix group cache for the go-builds. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
windowscache
branch
from
dd1ea02
to
4c5391e
Compare
arun-shopify
pushed a commit
to Shopify/opentelemetry-collector-contrib
that referenced
this pull request
Sep 1, 2022
The current cache has a race condition and last executed job in the matrix most likely will save that cache since it has same name for all executions. * Add a setup job that downloads all go mod deps and caches them. * Add a per matrix group cache for the go-builds. Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current cache has a race condition and last executed job in the matrix most likely will save that cache since it has same name for all executions.
FYI: Re-create (#10873), for some reasons I could not reopen that PR.
Signed-off-by: Bogdan Drutu [email protected]