Add Regular Expression Parser to Carbon Receiver #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a parser to Carbon receiver that allows to extract label keys and values from the metric "path".
owais
reviewed
Feb 20, 2020
owais
approved these changes
Feb 21, 2020
tigrannajaryan
approved these changes
Feb 21, 2020
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
Creating an example app that showcases how an application integrates with opentelemetry.
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
vastin
pushed a commit
to vastin/opentelemetry-collector-contrib
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a parser to Carbon receiver that allows extracting label keys and values from the metric "path" on the Carbon format. This is useful to break hierarchical path names used in Carbon to label keys and values while also allowing renaming the metrics.
Refactored the plaintext parser so the code handling the Carbon "line" was shared between the parsers that only treat the "metric path" differently - no changes to that code it was just moved to its own type.