[receiver/receiver_creator] correct watch_observers references to extension instances #12801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
receiver-creator-obs-cid
branch
from
8376554
to
a8c2448
Compare
rmfitzpatrick
changed the title
rmfitzpatrick
force-pushed
the
receiver-creator-obs-cid
branch
2 times, most recently
from
573415d
to
3b32426
Compare
jvoravong
approved these changes
Aug 3, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
rmfitzpatrick
force-pushed
the
receiver-creator-obs-cid
branch
from
3b32426
to
47ff891
Compare
dmitryax
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing a bug - Currently the Receiver Creator
watch_observersfield is[]config.Typeinstead of supporting the actual extension instance'sconfig.ComponentID. These changes* update the field to allow multiple observers of the same type.Testing: Updated existing tests to support multiple observers of same type.
Documentation: None required as readme suggests this has always been the case.