Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza/fileconsumer] Add tests for positional scanner #12783

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

djaglowski
Copy link
Member

This PR also renames the file from positional_scanner.go to scanner.go,
since the adjective is extraneous within the context of the package.

This PR does not affect functionality of the collector.

This PR also renames the file from positional_scanner.go to scanner.go,
since the adjective is extraneous within the context of the package.

This PR does not affect functionality of the collector.
@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 29, 2022
@djaglowski djaglowski marked this pull request as ready for review July 29, 2022 18:30
@djaglowski djaglowski requested a review from a team as a code owner July 29, 2022 18:30
@djaglowski djaglowski requested a review from dashpole July 29, 2022 18:30
@djaglowski djaglowski merged commit 4467071 into open-telemetry:main Aug 1, 2022
@djaglowski djaglowski deleted the pkg-stanza-scanner-tests branch August 1, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants