[pkg/telemetryquerylanguage] Move common functions to telemetryquerylanguage pkg #12739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @kentquirk |
TylerHelmuth
changed the title
djaglowski
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR moves functions from the transform processor that do not rely on pdata. Since this package could be used externally, its common functions cannot have assumptions that that the incoming data is pdata.
The functions are copied from the transform processor. There as been no functional change except to make the functions public.
The transform processor will be updated to use these functions in a later PR.
Link to tracking Issue:
Works towards #11751
Testing:
Ran unit tests
Documentation:
Added new function documentation.