[receiver/receivercreator] Ensure unique receiver names #12670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ec753b
to
7fe3984
Compare
7fe3984
to
c05cb57
Compare
7cfd65e
to
f941f04
Compare
f941f04
to
ca1bc30
Compare
jvoravong
approved these changes
Aug 3, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a feature - Currently receiver creator-generated receiver instances will use the same ComponentID by their endpoint (
observer.Endpoint.Target), which can cause collisions when multipleobserver.Endpointinstances have the same target value. These changes provide EndpointID suffixes to their names to prevent this.Testing: Modifies existing unit tests.
Documentation: changelog only since this is internal id.