[receiver/hostmetricsreceiver] add process.parent_pid attribute to process metrics #12637
Conversation
| return -1, err | ||
| } | ||
|
|
||
| // if a process does not have a parent return the pid of the process as it's own parent |
There was a problem hiding this comment.
this should not happen but gops does report some processes as having no parent.
There was a problem hiding this comment.
Why returning process's PID as parent PID? Is this some adopted fallback?
There was a problem hiding this comment.
Yes, just using it as a fallback. I don't think it's serious enough of an error to report or fail the scrape.
There was a problem hiding this comment.
Shouldn't it be 0 as it mostly represents no parent AFAIR?
There was a problem hiding this comment.
Technically speaking every process should have a parent. If no immediate relative is found then pid 1 (init process) becomes the parent. I can set it to 0 though. Would like to avoid using 1 so that we can distinguish between processes where the parent is clearly identified vs processes where we were not able to identify the parent.
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper_test.go
Show resolved
Hide resolved
| return -1, err | ||
| } | ||
|
|
||
| // if a process does not have a parent return the pid of the process as it's own parent |
There was a problem hiding this comment.
Why returning process's PID as parent PID? Is this some adopted fallback?
|
Issue created in opentelemtry-specification repo to add parent.process_id to spec open-telemetry/opentelemetry-specification#2689 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Description:
added process.parent_pid to hostmetricsreceiver process attributes
Link to tracking Issue:
#12290
Testing:
Ran on ubuntu box
Documentation:
n/a
cc: @dmitryax