[exporter/datadog] Use github.com/DataDog/datadog-agent/pkg/otlp/model for attributes
#12352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el` for attributes
mx-psi
force-pushed
the
mx-psi/use-attributes-from-model
branch
from
5d96133
to
8bc033f
Compare
amenasria
approved these changes
Jul 13, 2022
mx-psi
added
the
ready to merge
codeboten
approved these changes
Jul 13, 2022
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…el` for attributes (open-telemetry#12352) * [exporter/datadog] Use `github.com/DataDog/datadog-agent/pkg/otlp/model` for attributes * Test if an empty commit will make CI pass
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
…el` for attributes (#12352) * [exporter/datadog] Use `github.com/DataDog/datadog-agent/pkg/otlp/model` for attributes * Test if an empty commit will make CI pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Use
github.com/DataDog/datadog-agent/pkg/otlp/model/attributesto replace theinternal/model/attributescode.The two packages are identical (modulo some comments), so this is only an internal refactor with no visible changes.