[receiver/vcenter] vcenter.vm.disk.utilization calculation fix #12343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djaglowski do you mind taking a look at this? |
|
@schmikei, as noted on the linked issue, please split this into separate PRs. One of these changes is a bug fix, another is breaking, and another is a nop (if the metric was never returned). |
…tor-contrib into vcenter-vm-disk-utilization-calculation-fix
djaglowski
approved these changes
Jul 13, 2022
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…telemetry#12343) * calculate disk utilization for VMs more appropriately * remove vcenter.vm.cpu.utilization metric from metadata.yaml * add changelog entry * add vcenter.cluster.name resource attribute to datastore metrics * single out issue of vm.disk.utilization
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
* calculate disk utilization for VMs more appropriately * remove vcenter.vm.cpu.utilization metric from metadata.yaml * add changelog entry * add vcenter.cluster.name resource attribute to datastore metrics * single out issue of vm.disk.utilization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
vcenter.vm.disk.utilizationnowLink to tracking Issue: Resolves #12342
Testing: ensured via existing tests correct value was reported
Documentation: Changelog documentation