[processor/metricstransform] Do not produce empty metrics #12211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some transformations can leave metrics with no data points. Those metrics can be considered invalid and should not be generated. This change updates metricstransform processor to not produce empty metrics.
dmitryax
force-pushed
the
metric-transform-remov-empty-metric
branch
from
1f3c998
to
7b04502
Compare
dmitryax
changed the title
|
cc @TylerHelmuth as you reviewed it before :) |
TylerHelmuth
approved these changes
Jul 11, 2022
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…etry#12211) * Do not produce empty metrics Some transformations can leave metrics with no data points. Those metrics can be considered invalid and should not be generated. This change updates metricstransform processor to not produce empty metrics. * add a comment
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
* Do not produce empty metrics Some transformations can leave metrics with no data points. Those metrics can be considered invalid and should not be generated. This change updates metricstransform processor to not produce empty metrics. * add a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some transformations can leave metrics with no data points. Those metrics can be considered invalid and should not be generated. This change updates metricstransform processor to not produce empty metrics.
Resolves #12210