change OR to AND logic for filtering logs #12198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne for span filtering
dmitryax
reviewed
Jul 8, 2022
Comment on lines
-96
to
-97
| if mp.severityTextFilters != nil && mp.severityTextFilters.Matches(lr.SeverityText()) { | ||
| return true |
There was a problem hiding this comment.
Why this didn't work for #11439 before?
There was a problem hiding this comment.
if the severity didn't match, it would simply go to the next check (attributes) - and this would match (empty expected attributes means it always matches).
I've added a missing test case that reproduced this behavior.
There was a problem hiding this comment.
Makes sense. Thanks for clarifying!
dmitryax
approved these changes
Jul 11, 2022
Comment on lines
-96
to
-97
| if mp.severityTextFilters != nil && mp.severityTextFilters.Matches(lr.SeverityText()) { | ||
| return true |
There was a problem hiding this comment.
Makes sense. Thanks for clarifying!
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
change OR to AND logic for filtering logs - as desribed, and as is done for span filtering
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
change OR to AND logic for filtering logs - as desribed, and as is done for span filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change OR to AND logic for filtering logs - as desribed, and as is done for span filtering
Fixes #11439