adding support for linux/ppc64le arch #12166
Conversation
|
@jpkrohling |
|
please run the workflow. excluding the ppc64le arch for darwin and windows. |
|
Did you have to exclude Windows and Darwin for the core repository as well? |
no, I didn't have to exclude it in core repo. |
|
I assume the problem is then that a specific component can't be compiled on those platforms. Would you please open a ticket to address that? We should record this somewhere, as it would certainly leave us wondering in the future why core has the whole set, and contrib has some exclusions. |
|
the collector-core uses goreleaser to build the binaries and goreleaser is smart enough to understand that ppc64le arch isn't supported on windows and darwin. on the other hand, for collector-contrib we're cross compiling the binaries using the golang compiler itself. |
|
Got it, thanks for the clarification! |
|
Please review and merge. |
|
@djaglowski, shouldn't this have failed due to the lack of changelog entries? |
|
@dmitryax |
|
@jpkrohling, this appears to be due to #12194. The problem was resolved, but a rebase would be necessary to pick up the fix. @adilhusain-s, please rebase and add a changelog entry according to |
|
@djaglowski does this line look good for change log?
|
|
Yes, I think that line is fine. |
adilhusain-s
force-pushed
the
ot-ppc64le
branch
2 times, most recently
from
405e07f
to
5fa98a9
Compare
|
@jpkrohling |
|
@djaglowski |
Adding support for linux/ppc64le arch
Adding support for linux/ppc64le arch
Hi there,
I've successfully built and tested the opentelemetry-collector-contrib on power VM.
please review and merge.
Resolves #12350