[exporter/datadog] Remove deprecated configuration features #12110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes both the environment variable detection as well as the deprecated settings.
mx-psi
force-pushed
the
mx-psi/remove-deprecated-options
branch
from
b2200c4
to
f4105d2
Compare
gbbr
reviewed
Jul 6, 2022
gbbr
reviewed
Jul 7, 2022
This one is to the PR, since we don't have a dedicated issue
gbbr
approved these changes
Jul 8, 2022
mx-psi
added
the
ready to merge
dashpole
approved these changes
Jul 11, 2022
mx-psi
removed
the
ready to merge
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…emetry#12110) * [exporter/datadog] Remove deprecated configuration features This includes both the environment variable detection as well as the deprecated settings. * Add release note * Revert deletion of `max_events_per_second` This will be done in open-telemetry#12109 * Unify remaining config*.go files * Add test cases for custom errors on renamed settings * Add message for `metrics::instrumentation_library_metadata_as_tags` * [exporter/datadog] Refactor code for removed settings * Add link for `instrumentation_library_metadata_as_tags` removal This one is to the PR, since we don't have a dedicated issue * Address feedback
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
* [exporter/datadog] Remove deprecated configuration features This includes both the environment variable detection as well as the deprecated settings. * Add release note * Revert deletion of `max_events_per_second` This will be done in #12109 * Unify remaining config*.go files * Add test cases for custom errors on renamed settings * Add message for `metrics::instrumentation_library_metadata_as_tags` * [exporter/datadog] Refactor code for removed settings * Add link for `instrumentation_library_metadata_as_tags` removal This one is to the PR, since we don't have a dedicated issue * Address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
host_metadatasection to group related settings #9099, [exporter/datadog] Removeenvsetting #9016, [exporter/datadog] Renamemetrics::report_quantilestometrics::summaries::mode#8845, [exporter/datadog] Removeversionsetting #8783, [exporter/datadog] Removeservicesetting #8781, [exporter/datadog] Renamemetrics::send_monotonic_countertometrics::sums::cumulative_monotonic_mode#8489)Link to tracking Issue: fixes #9099, fixes #9016, fixes #8845, fixes #8783, fixes #8781, fixes #8489, fixes #8396