Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Chrony Receiver ] Part 1 - Adding initial component #12101

Merged
merged 1 commit into from
Jul 19, 2022
Merged

[ Chrony Receiver ] Part 1 - Adding initial component #12101

merged 1 commit into from
Jul 19, 2022

Conversation

MovieStoreGuy
Copy link
Contributor

Description:
Adding in the configuration of the Chrony Receiver to be added along with
the metadata metric configuration.

Link to tracking Issue:
#11789

Testing:
The default unit testing of the configuration object

Documentation:
A readme along with the generated documentation for the metdata.yml has been added.

@MovieStoreGuy MovieStoreGuy requested review from a team and TylerHelmuth July 6, 2022 02:30
@MovieStoreGuy MovieStoreGuy mentioned this pull request Jul 6, 2022
Merged
@MovieStoreGuy MovieStoreGuy changed the title [ Chrony Receiver ] Adding initial component [ Chrony Receiver ] Part 1 - Adding initial component Jul 6, 2022
jpkrohling
jpkrohling reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a couple of minor issues, this LGTM.

.github/CODEOWNERS Outdated Show resolved Hide resolved
receiver/chronyreceiver/README.md Outdated Show resolved Hide resolved
receiver/chronyreceiver/README.md Outdated Show resolved Hide resolved
receiver/chronyreceiver/README.md Outdated Show resolved Hide resolved
receiver/chronyreceiver/README.md Outdated Show resolved Hide resolved
receiver/chronyreceiver/README.md Outdated Show resolved Hide resolved
receiver/chronyreceiver/README.md Show resolved Hide resolved
receiver/chronyreceiver/config.go Outdated Show resolved Hide resolved
@MovieStoreGuy MovieStoreGuy force-pushed the msg/part-1-chrony-receiver branch 2 times, most recently from 0c08141 to dcdb4e9 Compare July 8, 2022 04:10
jamesmoessis
jamesmoessis approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@jamesmoessis jamesmoessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also reviewed internally, and still LGTM, just two minor nits.

receiver/chronyreceiver/metadata.yaml Outdated Show resolved Hide resolved
jpkrohling
jpkrohling reviewed Jul 11, 2022
View reviewed changes
receiver/chronyreceiver/README.md Outdated Show resolved Hide resolved
receiver/chronyreceiver/README.md Outdated Show resolved Hide resolved
receiver/chronyreceiver/testdata/config.yml Outdated Show resolved Hide resolved
@MovieStoreGuy
Copy link
Contributor Author

@jpkrohling could I get you to double check this?

@MovieStoreGuy
[ Chrony Receiver ] Adding initial component
2c9ee6c 
Adding in the conguration of the Chrony Receiver to be added along with
the metadata metric configuration.
jpkrohling
jpkrohling approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling jpkrohling merged commit 069d123 into open-telemetry:main Jul 19, 2022
@crobert-1 crobert-1 mentioned this pull request Aug 26, 2024
Merged
codeboten pushed a commit that referenced this pull request Aug 28, 2024
@crobert-1
[chore][receiver/chrony] Fix readme config references (#34846)
8bb1fe4 
The README is referencing a config option as `address`, but it's
actually `endpoint`. This incorrect reference was introduced in the
[original PR introducing this
component](#12101).

Fixes #34839
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
@crobert-1 @f7o
[chore][receiver/chrony] Fix readme config references (open-telemetry…
8e0618c 
…#34846)

The README is referencing a config option as `address`, but it's
actually `endpoint`. This incorrect reference was introduced in the
[original PR introducing this
component](open-telemetry#12101).

Fixes open-telemetry#34839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@jamesmoessis jamesmoessis jamesmoessis approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth

@dmitryax dmitryax Awaiting requested review from dmitryax

Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MovieStoreGuy @jpkrohling @jamesmoessis @dmitryax