Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receiver/azureblobreceiver First PR #11872

Merged
merged 32 commits into from
Aug 11, 2022

Conversation

eedorenko
Copy link
Contributor

Description:
azureblobreceiver reads logs and traces from Azure Blob Storage.

Fixes #8834

Documentation:
Readme describing receiver functionality and configuration.

@eedorenko eedorenko requested a review from a team as a code owner July 1, 2022 18:05
@eedorenko eedorenko requested a review from Aneurysm9 July 1, 2022 18:05
@mx-psi mx-psi requested a review from pmm-sumo July 5, 2022 14:51
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmm-sumo please review

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 26, 2022
@codeboten
Copy link
Contributor

pmm-sumo is no longer involved in the project. @mx-psi as the next sponsor on the list, please review this component.

codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this pull request Jul 27, 2022
Removing pmm-sumo, moving @Aneurysm9 and @mx-psi to the bottom of the rotation after sponsoring: open-telemetry#11872 open-telemetry#11871
@github-actions github-actions bot removed the Stale label Jul 28, 2022
bogdandrutu pushed a commit that referenced this pull request Aug 1, 2022
Removing pmm-sumo, moving @Aneurysm9 and @mx-psi to the bottom of the rotation after sponsoring: #11872 #11871
receiver/azureblobreceiver/README.md Outdated Show resolved Hide resolved
receiver/azureblobreceiver/README.md Outdated Show resolved Hide resolved
receiver/azureblobreceiver/factory.go Show resolved Hide resolved
receiver/azureblobreceiver/go.mod Outdated Show resolved Hide resolved
@eedorenko eedorenko requested a review from mx-psi August 8, 2022 22:37
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few more comments

go.mod Outdated Show resolved Hide resolved
receiver/azureblobreceiver/factory.go Outdated Show resolved Hide resolved
receiver/azureblobreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/azureblobreceiver/README.md Outdated Show resolved Hide resolved
@eedorenko eedorenko requested a review from mx-psi August 10, 2022 00:42
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"go.opentelemetry.io/collector/config"
)

type Config struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a follow up PR to document the fields directly in the Go struct? This is not urgent, but will be useful in the future for automatic configuration schema generation

@mx-psi
Copy link
Member

mx-psi commented Aug 10, 2022

You need to add this component to .github/CODEOWNERS. You can list yourself and also me as the sponsor.

FAIL: "receiver/azureblobreceiver" not included in CODEOWNERS

.github/CODEOWNERS Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member

mx-psi commented Aug 10, 2022

Looks good, will merge once all tests pass (probably tomorrow morning first thing if nobody else has done it :))

@mx-psi mx-psi merged commit e11aa63 into open-telemetry:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New component: Azure Blob Receiver
4 participants