[processor/transform] Add enum capabilities to grammar and contexts #11787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
a team,
Aneurysm9 and
bogdandrutu
as code owners
anuraaga
reviewed
Jun 30, 2022
anuraaga
approved these changes
Jun 30, 2022
|
@open-telemetry/collector-contrib-approvers please review |
djaglowski
approved these changes
Jul 8, 2022
TylerHelmuth
added
ready to merge
TylerHelmuth
added
the
ready to merge
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…pen-telemetry#11787) * Add enum capabilities to grammar and contexts * Updated changelog and readme * Update changelog entry
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
…11787) * Add enum capabilities to grammar and contexts * Updated changelog and readme * Update changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds to the grammar the ability to handle enums. All Enums are int64. Enums are always used as native int64s in Conditions to ensure comparison between either an Enum or an int64 works as expected. If a function wants to use an Enum as a parameter, it must use the Enum type.
Contexts must supply a ParseEnum function that will attempt to parse a path as an enum. This allows contexts to define their own symbol tables.
All contexts' enum accessors have been updated to Get and Set enums as int64s.
Link to tracking Issue:
Fixes #10349
Testing:
Updated and added unit tests.
Documentation:
Updated README