[datadogexporter] Implement translation of metrics to Datadog format #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be expanded in the future to more closely replicate the Datadog Agent behavior
Codecov Report
@@ Coverage Diff @@
## master #1178 +/- ##
===========================================
+ Coverage 76.01% 89.79% +13.78%
===========================================
Files 24 285 +261
Lines 1163 13873 +12710
===========================================
+ Hits 884 12457 +11573
- Misses 226 1047 +821
- Partials 53 369 +316
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
We can add it back if necessary in the future
KSerrania
approved these changes
Oct 2, 2020
bogdandrutu
approved these changes
Oct 3, 2020
|
Please rebase |
|
@bogdandrutu Done! |
6 tasks
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
#1178) OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS env var can be set to a command separated list of attributes names that will be extracted from Tornado's request object and set as attributes on spans. Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
#1178) OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS env var can be set to a command separated list of attributes names that will be extracted from Tornado's request object and set as attributes on spans. Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
#1178) OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS env var can be set to a command separated list of attributes names that will be extracted from Tornado's request object and set as attributes on spans. Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
#1178) OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS env var can be set to a command separated list of attributes names that will be extracted from Tornado's request object and set as attributes on spans. Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
codeboten
pushed a commit
that referenced
this pull request
Nov 23, 2022
#1178) OTEL_PYTHON_TONADO_TRACED_REQUEST_ATTRS env var can be set to a command separated list of attributes names that will be extracted from Tornado's request object and set as attributes on spans. Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add utilities to translate
pdata.Metricsinto Datadog metrics and obtain a valid hostname.For the metrics translation we are not relying on OpenCensus helpers as other exporters do based on this Gitter thread. This implies some testing limitations (see Testing section).
The hostname resolution is currently very simple but will be expanded in future PRs.
Link to tracking Issue: n/a
Testing:
I added unit tests to test mapping every metric type; the
MapMetricsfunction can't be tested easily since constructing apdata.Metricsstruct relies on internalopentelemetry-collectorpackages that can't be imported from theopentelemetry-collector-contribmodules.I also added a unit test for the hostname resolution.
Documentation: Configuration options and the intended exporter behavior were documented on #1142; this PR adds documentation on each function.