Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Start using datadog-agent OTLP module #11537

Merged
merged 6 commits into from
Jul 8, 2022

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 24, 2022

Description:

This is the first PR on re-doing #5860 piece by piece. Part of the code on the Datadog exporter is shared with the Datadog Agent. This code lives in the github.com/DataDog/datadog-agent/pkg/otlp/model Go module.

This first PR only replaces all usages of github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter/internal/model/source by github.com/DataDog/datadog-agent/pkg/otlp/model/source. Subsequent PRs will continue with the rest.

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 24, 2022
@mx-psi mx-psi marked this pull request as ready for review June 28, 2022 14:28
@mx-psi mx-psi requested a review from a team as a code owner June 28, 2022 14:28
@mx-psi mx-psi requested a review from djaglowski June 28, 2022 14:28
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Jul 4, 2022
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase 👍🏻

@mx-psi
Copy link
Member Author

mx-psi commented Jul 6, 2022

@codeboten done

@mx-psi
Copy link
Member Author

mx-psi commented Jul 6, 2022

Need to rebase again...

@mx-psi
Copy link
Member Author

mx-psi commented Jul 6, 2022

Alright, this is ready to merge again

@codeboten codeboten merged commit dc372e0 into open-telemetry:main Jul 8, 2022
@mx-psi mx-psi deleted the mx-psi/start-using-model branch November 2, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants