Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splunkhecreceiver: allow multiple Start() calls #11517

Merged

Conversation

rmfitzpatrick
Copy link
Contributor

Description:
Fixing a bug - With open-telemetry/opentelemetry-collector@b05c0f3 using the splunk_hec receiver in multiple pipelines causes a port conflict by trying to recreate an existing server. These changes ensure subsequent Start() calls are noops.

Testing: Updated existing test with repeated Start invocation.

Documentation: Changelog update

@rmfitzpatrick rmfitzpatrick requested review from a team and codeboten June 23, 2022 17:55
@rmfitzpatrick rmfitzpatrick force-pushed the splunkhecreceivermultiplestart branch 2 times, most recently from b89b698 to 1597e1e Compare June 23, 2022 18:15
@rmfitzpatrick rmfitzpatrick force-pushed the splunkhecreceivermultiplestart branch from 1597e1e to 578f046 Compare June 23, 2022 18:57
@dmitryax dmitryax added the ready to merge Code review completed; ready to merge by maintainers label Jun 23, 2022
@dmitryax dmitryax merged commit 2e5adcd into open-telemetry:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants