Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose anuraaga@ as approver for otel-collector-contrib #1114

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Propose anuraaga@ as approver for otel-collector-contrib #1114

merged 1 commit into from
Sep 24, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 24, 2020 •
edited
Loading

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team as a code owner September 24, 2020 01:04
@bogdandrutu
Copy link
Member Author

/cc @anuraaga

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #1114 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1114   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         258      258           
  Lines       12330    12330           
=======================================
  Hits        10967    10967           
  Misses       1011     1011           
  Partials      352      352
Flag Coverage Δ
#integration 75.52% <ø> (+0.10%) ⬆️
#unit 87.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9c588...6cd234e. Read the comment docs.

anuraaga
anuraaga approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tigrannajaryan
Copy link
Member

Welcome @anuraaga ! Good to have your help.

If you haven't had a chance please read the contributing docs 1 and 2 so that you can enforce the guidelines as an approver :-)

@tigrannajaryan tigrannajaryan merged commit 3332fe4 into open-telemetry:master Sep 24, 2020
dyladan referenced this pull request in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@dmitryax
Fix typo in config error messages (#1114)
96e596d
@bogdandrutu bogdandrutu deleted the anuraaga branch February 1, 2021 20:42
codeboten pushed a commit that referenced this pull request Nov 23, 2022
@rydzykje @codeboten
Support Environment Variables for JaegerSpanExporter configuration (#…
dbef5cb 
…1114)
codeboten added a commit that referenced this pull request Nov 23, 2022
@codeboten
Revert "Support Environment Variables for JaegerSpanExporter configur…
2fdd57a 
…ation (#1114)"

This reverts commit dbef5cb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@pjanotti pjanotti pjanotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @tigrannajaryan @anuraaga @pjanotti