Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] add instrumentation_scope_metadata_as_tags #11135

Merged

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Jun 18, 2022

Description:

Deprecate instrumentation_library_metadata_as_tags and add instrumentation_scope_metadata_as_tags for the new recommended flag.
DataDog/datadog-agent#12393 is the same work in Datadog Agent side.

Link to tracking Issue:

Testing:

Documentation:

@keisku keisku requested review from a team and mx-psi as code owners June 18, 2022 01:56
@project-bot project-bot bot added this to In progress in Collector Jun 18, 2022
@keisku keisku requested a review from mx-psi June 21, 2022 22:25
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you just need to fix the merge conflicts

@keisku keisku requested a review from mx-psi June 22, 2022 08:24
CHANGELOG.md Show resolved Hide resolved
@keisku keisku requested a review from mx-psi June 22, 2022 08:36
Collector automation moved this from In progress to Reviewer approved Jun 22, 2022
@mx-psi mx-psi merged commit bfdaa34 into open-telemetry:main Jun 22, 2022
@keisku keisku deleted the add-instrumentation_scope_metadata_as_tags branch July 12, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Reviewer approved
Development

Successfully merging this pull request may close these issues.

None yet

3 participants