Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: move from github.com/pkg/errors to 'errors' and 'fmt' #11114

Merged
merged 3 commits into from
Jun 30, 2022
Merged

deps: move from github.com/pkg/errors to 'errors' and 'fmt' #11114

merged 3 commits into from
Jun 30, 2022

Conversation

mmorel-35
Copy link
Contributor

Description:
The package https://github.com/pkg/errors is not maintained anymore.
This PR replaces https://github.com/pkg/errors with official errors and fmt golang packages

Signed-off-by: Matthieu MOREL [email protected]

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 17, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mmorel-35 / name: Matthieu MOREL (7284229)

@project-bot project-bot bot added this to In progress in Collector Jun 17, 2022
@mmorel-35 mmorel-35 marked this pull request as draft June 17, 2022 21:36
@mmorel-35 mmorel-35 marked this pull request as ready for review June 18, 2022 07:48
bogdandrutu
bogdandrutu approved these changes Jun 27, 2022
View reviewed changes
receiver/k8sclusterreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/k8sclusterreceiver/watcher.go Outdated Show resolved Hide resolved
Collector automation moved this from In progress to Reviewer approved Jun 27, 2022
@mx-psi
Copy link
Member

mx-psi commented Jun 28, 2022

@mmorel-35 can you fix the merge conflict?

@mmorel-35
Copy link
Contributor Author

Hi @mx-psi ,
The conflict has been handled.

dmitryax
dmitryax reviewed Jun 30, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 30, 2022
@mmorel-35
clean changelog
b6534c9 
Signed-off-by: Matthieu MOREL <[email protected]>
@mx-psi mx-psi merged commit 89d6115 into open-telemetry:main Jun 30, 2022
@mmorel-35 mmorel-35 deleted the pkg/errors branch June 30, 2022 15:39
atoulme pushed a commit to atoulme/opentelemetry-collector-contrib that referenced this pull request Jul 16, 2022
@mmorel-35 @atoulme
deps: move from github.com/pkg/errors to 'errors' and 'fmt' (open-tel…
9c6bade 
…emetry#11114)

* deps: move from github.com/pkg/errors to 'errors' and 'fmt'

Signed-off-by: Matthieu MOREL <[email protected]>

* clean changelog

Signed-off-by: Matthieu MOREL <[email protected]>

Co-authored-by: Matthieu MOREL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@mx-psi mx-psi mx-psi approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@pmm-sumo pmm-sumo Awaiting requested review from pmm-sumo

Assignees

@jpkrohling jpkrohling

@dashpole dashpole

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Collector
  
Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mmorel-35 @mx-psi @bogdandrutu @dmitryax @jpkrohling @dashpole