Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/coralogixexporter] add coralogix metrics exporter #11065

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[exporter/coralogixexporter] add coralogix metrics exporter #11065

merged 1 commit into from
Jun 29, 2022

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jun 16, 2022 •
edited
Loading

Description:

Add support for metrics in coralogixexporter.

Link to tracking Issue:

Testing:

  • Added unit tests

Tested locally using following configurations:

  • metrics only
  • traces only
  • both metrics and traces

Documentation:

@povilasv povilasv force-pushed the coralogixexporter-metrics branch 2 times, most recently from f1fd0ac to 2d583f5 Compare June 16, 2022 13:22
@povilasv povilasv marked this pull request as ready for review June 16, 2022 14:41
@povilasv povilasv requested review from a team and mx-psi June 16, 2022 14:41
mx-psi
mx-psi reviewed Jun 17, 2022
View reviewed changes
exporter/coralogixexporter/go.mod Outdated Show resolved Hide resolved
exporter/coralogixexporter/metrics_client.go Show resolved Hide resolved
exporter/coralogixexporter/exporter.go Show resolved Hide resolved
exporter/coralogixexporter/factory.go Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member

mx-psi commented Jun 17, 2022

@oded-dd @ofirshmuel to review as CODEOWNERs

@povilasv povilasv force-pushed the coralogixexporter-metrics branch 10 times, most recently from e37cb3e to c6a0e04 Compare June 29, 2022 06:30
@povilasv
Copy link
Contributor Author

@mx-psi thanks so much for reviews, I think all the issues are fixed and I'm ready for another round 💪

@mx-psi mx-psi merged commit 1052ae6 into open-telemetry:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@oded-dd oded-dd oded-dd approved these changes

Assignees

@Aneurysm9 Aneurysm9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@povilasv @mx-psi @oded-dd @Aneurysm9