[exporter/datadog] Add ECS Fargate source provider #11030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct way is to build the zero value of an error and pass its pointer
KSerrania
approved these changes
Jun 17, 2022
exporter/datadogexporter/internal/metadata/internal/ecs/provider.go
Outdated
Show resolved
Hide resolved
exporter/datadogexporter/internal/model/translator/metrics_translator.go
Outdated
Show resolved
Hide resolved
9 tasks
codeboten
reviewed
Jun 20, 2022
|
@codeboten done! |
codeboten
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The source refactor is entirely internal. The ECS Fargate logic will be exposed by #10926 but this PR needs no changelog since this logic is behind a constant for now.
Link to tracking Issue: #10424
Testing: Added unit tests.