Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix check module version to account for space at end of module #10885

Merged
merged 1 commit into from
Jun 10, 2022
Merged

[ci] Fix check module version to account for space at end of module #10885

merged 1 commit into from
Jun 10, 2022

Conversation

hickeyma
Copy link
Contributor

When module dependency is on its only require line, then need to check for modules with space at end as well

Thanks @dashpole for finding this in #10840.

@hickeyma
Fix check module version check
f9ab7c4 
When module dependency on its only require line then need to check
for modules with spaces

Signed-off-by: Martin Hickey <[email protected]>
@hickeyma hickeyma requested a review from a team as a code owner June 10, 2022 14:16
@hickeyma hickeyma requested a review from dashpole June 10, 2022 14:16
@project-bot project-bot bot added this to In progress in Collector Jun 10, 2022
@hickeyma hickeyma mentioned this pull request Jun 10, 2022
Merged
Collector automation moved this from In progress to Reviewer approved Jun 10, 2022
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 10, 2022
@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Jun 10, 2022
@codeboten codeboten merged commit ae0f7f7 into open-telemetry:main Jun 10, 2022
@hickeyma hickeyma deleted the check-space-mod-versions branch June 10, 2022 16:50
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
@hickeyma @kentquirk
[ci] Fix check module version to account for space at end of module (o…
e9c515d 
…pen-telemetry#10885)

Fix check module version check

When module dependency on its only require line then need to check
for modules with spaces

Signed-off-by: Martin Hickey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dashpole dashpole dashpole approved these changes

@mx-psi mx-psi mx-psi approved these changes

Assignees

@pmm-sumo pmm-sumo

Labels
ready to merge Code review completed; ready to merge by maintainers Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Collector
  
Reviewer approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hickeyma @codeboten @dashpole @mx-psi @pmm-sumo