[exporter/tanzuobservability] Refactor histogram codes #10860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oppegard
reviewed
Jun 9, 2022
thepeterstone
approved these changes
Jun 10, 2022
oppegard
approved these changes
Jun 22, 2022
|
@open-telemetry/collector-approvers anyone else review this please? |
jpkrohling
reviewed
Jul 7, 2022
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ | |||
| - `prometheusreceiver`: Add `target_info` labels to resource attributes. (#11034) | |||
| - `saphanareceiver`: Fix component memory query, add better error handling (#11507) | |||
| - `sapmexporter`: Add config option to log responses from Splunk APM. (#11425) | |||
| - `tanzuobservabilityexporter`: Improve alorithm to translate OTEL delta exponential histograms into tanzu observability histograms (#10860) | |||
There was a problem hiding this comment.
We've recently changed how changelog entries are handled. Please, check the contribution guidelines, but in short, you'll just need to add a new file to ./unreleased.
Make histogram code be more like the WF proxy code.
|
Thanks @jpkrohling I added a .yaml file under the unreleased directory for CHANGELOG.md. |
jpkrohling
reviewed
Jul 8, 2022
|
Hi. Before the build was green, but since I added a .yaml file for the change log, one of the load tests is failing. Could it be a flaky test? |
Yes |
|
Hi @jpkrohling, I fixed the misspelling that you caught in my CHANGELOG entry. Good catch by the way. Please reach out if there is anything else. Thanks. |
jpkrohling
approved these changes
Jul 12, 2022
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
…y#10860) * [exporter/tanzuobservability] Refactor histogram codes Make histogram code be more like the WF proxy code. * Get rid of redundant comments. * Enhance accuracy of delta histograms. * Switch to new method of updating CHANGELOG.md * Fix misspelling in CHANGELOG
ag-ramachandran
referenced
this pull request
in ag-ramachandran/opentelemetry-collector-contrib
Sep 15, 2022
* [exporter/tanzuobservability] Refactor histogram codes Make histogram code be more like the WF proxy code. * Get rid of redundant comments. * Enhance accuracy of delta histograms. * Switch to new method of updating CHANGELOG.md * Fix misspelling in CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make histogram code be more like the WF proxy code.
Description:
Refactor the histogram code to make it more like the WF proxy code. Also make exponential delta histogram code more accurate.
Testing:
Unit testing.