-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow to create dependabot pr #10841
add workflow to create dependabot pr #10841
Conversation
This pr adds a workflow to replace the manual work required to commit all the dependabot PRs. The workflow: - checks out the code - runs .github/workflows/scripts/dependabot-pr.sh which looks for all dependabot PRs and applies the dependency update - runs tidy/builds the collector - commits a change and creates a PR The workflow is triggered manually and the GITHUB_ACTOR who triggered the workflow is the user used to create the PR.
4c45833
to
c8df22d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a script you've been running locally? Have you been able to test it as a github action?
#!/bin/bash -ex | ||
|
||
git config user.name $GITHUB_ACTOR | ||
git config user.email [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this handle the situation where the workflow starter is using the "Keep my email addresses private" option? For example, my users.noreply.github.com
email is [email protected]
. Will GITHUB_ACTOR
contain TylerHelmuth
or 12352919+TylerHelmuth
? Or does it not matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was mistaken, the GITHUB_ACTOR
is the github actions bot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either ways it doesn't look like the email matters to github
I've run it in my fork, you can see the resulting PR here: codeboten#2748 Here's the action being run: https://github.com/codeboten/opentelemetry-collector-contrib/runs/6802784258?check_suite_focus=true |
Co-authored-by: Tyler Helmuth <[email protected]>
* add workflow to create dependabot pr This pr adds a workflow to replace the manual work required to commit all the dependabot PRs. The workflow: - checks out the code - runs .github/workflows/scripts/dependabot-pr.sh which looks for all dependabot PRs and applies the dependency update - runs tidy/builds the collector - commits a change and creates a PR The workflow is triggered manually and the GITHUB_ACTOR who triggered the workflow is the user used to create the PR. * Update .github/workflows/scripts/dependabot-pr.sh Co-authored-by: Tyler Helmuth <[email protected]> * fix typo Co-authored-by: Tyler Helmuth <[email protected]>
This pr adds a workflow to replace the manual work required to commit all the dependabot PRs. The workflow:
The workflow is triggered manually and the PR will be opened by the github-actions bot