add error checks to googlecloudexporter package. #10373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiptoChakrabarty
requested review from
a team,
dashpole,
jsuereth and
punya
as code owners
dashpole
approved these changes
May 27, 2022
mx-psi
reviewed
May 27, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@DiptoChakrabarty could you look at @dashpole's comment and fix this? |
…ntelemetry-collector-contrib into googlecloudexporter
|
The changelog check is failing because the changelog process changed. I don't think this PR needs a changelog entry anyway, so could you just revert your changes to the |
mx-psi
approved these changes
Jul 3, 2022
atoulme
pushed a commit
to atoulme/opentelemetry-collector-contrib
that referenced
this pull request
Jul 16, 2022
* error checks for googlecloud exporter package * update changelog * stop srv with defer * remove changelog entry Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
adding error checks to googlecloudexporter package.
Link to tracking Issue:
#9749
Testing:
Documentation: