Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add status header for parquet exporter #10328

Merged

Conversation

Frapschen
Copy link
Contributor

Description:
Add status header for parquet exporter

@Frapschen Frapschen requested a review from a team as a code owner May 25, 2022 08:55
@Frapschen Frapschen requested a review from dmitryax May 25, 2022 08:55
@project-bot project-bot bot added this to In progress in Collector May 25, 2022
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 25, 2022
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not even functional, we should use "in-development" status

Collector automation moved this from In progress to Review in progress May 25, 2022
Frapschen and others added 2 commits May 25, 2022 21:44
Co-authored-by: Przemek Maciolek <[email protected]>
format table
Copy link
Contributor

@pmm-sumo pmm-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good overall

Collector automation moved this from Review in progress to Reviewer approved May 26, 2022
Co-authored-by: Przemek Maciolek <[email protected]>
@codeboten codeboten merged commit 5938052 into open-telemetry:main May 26, 2022
@Frapschen Frapschen deleted the Add_status_header_for_parquet branch May 29, 2022 23:46
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
* Add status header for parquet

* Apply suggestions from code review

Co-authored-by: Przemek Maciolek <[email protected]>

* Update README.md

format table

* Apply suggestions from code review

Co-authored-by: Alex Boten <[email protected]>

* Update README.md

* update for reviewer's suggestion

* Apply suggestions from code review

Co-authored-by: Przemek Maciolek <[email protected]>

Co-authored-by: Przemek Maciolek <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
No open projects
Collector
  
Reviewer approved
Development

Successfully merging this pull request may close these issues.

None yet

4 participants