[processor/transform] Update is_monotonic and aggregation_temporality accessor functions #10197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The access functions for metric's is_monotonic and aggregation_temporality fields were using the pmetric versions, but this didn't work in practice since the grammar doesn't know how to convert the incoming string to the exact pmetric equivalent.
Instead, I have updated the getters and setters to convert the pmetric type to an equivalent data type that the parser understands. This will allow the following scenarios to work:
Changing temporality:
set(metric.aggregation_temporality, 1) where metric.aggregation_temporality == 0
Changing monotonicity:
set(metric.is_monotonic, "true") where metric.is_monotonic == "false"
Testing:
Updated existing scenarios and added new test scenarios.
Documentation:
Updated readme.