Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exporter/sumologic: reuse Sender instead of creating it every time #33105

Closed
sumo-drosiek opened this issue May 17, 2024 · 4 comments
Closed

exporter/sumologic: reuse Sender instead of creating it every time #33105

sumo-drosiek opened this issue May 17, 2024 · 4 comments
Labels
closed as inactive enhancement New feature or request exporter/sumologic Stale

Comments

@sumo-drosiek
Copy link
Member

Component(s)

extension/sumologic

Is your feature request related to a problem? Please describe.

#33021 (comment)

Describe the solution you'd like

Initilize sender once and reuse it later

Describe alternatives you've considered

No response

Additional context

We should check if there is any reason to initilize exporter with every request, but I don't see any at first sight
@sumo-drosiek sumo-drosiek added enhancement New feature or request needs triage New item requiring triage labels May 17, 2024
@sumo-drosiek sumo-drosiek mentioned this issue May 17, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for exporter/sumologic: @aboguszewski-sumo @kkujawa-sumo @mat-rumian @rnishtala-sumo @sumo-drosiek @swiatekm-sumo. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Filed by code owner, removing needs triage.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label May 17, 2024
@chan-tim-sumo chan-tim-sumo mentioned this issue Jun 18, 2024
Merged
andrzej-stencel pushed a commit that referenced this issue Jun 28, 2024
@chan-tim-sumo
[exporter/sumologicexporter] Initialized sender to be reused instead …
a12660d 
…of creating it for each batch (#33643)

**Description:** 
Refactored sender to be created once and reused instead of creating a
new sender each batch.

**Link to tracking Issue:**
-
#33105
- jira: https://sumologic.atlassian.net/browse/OSC-751 

**Testing:** 

- Unit test passed 

**Documentation:**
- chloggen
@github-actions GitHub Actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed as inactive enhancement New feature or request exporter/sumologic Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@songy23 @sumo-drosiek @crobert-1