Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/cloudflare] Integration tests failing to find expected files #32532

Closed
crobert-1 opened this issue Apr 18, 2024 · 3 comments
Closed

[receiver/cloudflare] Integration tests failing to find expected files #32532

crobert-1 opened this issue Apr 18, 2024 · 3 comments
Assignees
@dehaansa
Labels
needs triage New item requiring triage receiver/cloudflare

Comments

@crobert-1
Copy link
Member

Component(s)

receiver/cloudflare

Describe the issue you're reporting

Failing CI/CD link

Note that this test hasn't been running for some time, as explained in #32207, so this failure may not be the result of a recent change.

Failure output:

Running target 'mod-integration-test' in module 'receiver/cloudflarereceiver' as part of group 'receiver-0'
make --no-print-directory -C receiver/cloudflarereceiver mod-integration-test
running go integration test ./... in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/cloudflarereceiver
/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 360s -parallel 4 -tags=integration,""
∅  internal/metadata
✖  . (144ms)

DONE 36 tests, 3 failures in 1.114s

✖  . (76ms)
✖  . (75ms)

=== Failed
=== FAIL: . TestReceiverTLS/all_fields (0.06s)
    logs_integration_test.go:112: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/cloudflarereceiver/logs_integration_test.go:112
        	Error:      	Received unexpected error:
        	            	open testdata/processed/all_fields.json: no such file or directory
        	Test:       	TestReceiverTLS/all_fields

make[2]: *** [../../Makefile.Common:142: mod-integration-test] Error 1
make[1]: *** [Makefile:165: receiver/cloudflarereceiver] Error 2
make: *** [Makefile:122: gointegration-test] Error 2
=== FAIL: . TestReceiverTLS/multiple_log_payload (0.06s)
    logs_integration_test.go:112: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/cloudflarereceiver/logs_integration_test.go:112
        	Error:      	Received unexpected error:
        	            	open testdata/processed/multiple_log_payload.json: no such file or directory
        	Test:       	TestReceiverTLS/multiple_log_payload

=== FAIL: . TestReceiverTLS (0.11s)

=== FAIL: . TestReceiverTLS/all_fields (re-run 1) (0.06s)
    logs_integration_test.go:112: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/cloudflarereceiver/logs_integration_test.go:112
        	Error:      	Received unexpected error:
        	            	open testdata/processed/all_fields.json: no such file or directory
        	Test:       	TestReceiverTLS/all_fields

=== FAIL: . TestReceiverTLS (re-run 1) (0.06s)

=== FAIL: . TestReceiverTLS/multiple_log_payload (re-run 1) (0.06s)
    logs_integration_test.go:112: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/cloudflarereceiver/logs_integration_test.go:112
        	Error:      	Received unexpected error:
        	            	open testdata/processed/multiple_log_payload.json: no such file or directory
        	Test:       	TestReceiverTLS/multiple_log_payload

=== FAIL: . TestReceiverTLS (re-run 1) (0.06s)

DONE 2 runs, 40 tests, 7 failures in 2.758s
make[1]: Leaving directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
@crobert-1 crobert-1 added the needs triage New item requiring triage label Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dehaansa dehaansa mentioned this issue Apr 19, 2024
Merged
djaglowski pushed a commit that referenced this issue Apr 19, 2024
@dehaansa
[chore][CI/CD] Fix cloudflare receiver integration test (#32547)
71dcf7a 
Fixed the expected file extension for golden metrics comparison in
cloudflare receiver integration test to be .yaml, not .json.

Due to the undocumented behavior of the Integration test Make tasks only
running tests containing the string 'Integration', this was broken when
golden metrics were changed in test from JSON to YAML in
#20438.


While the 'Integration' restriction is being addressed in
#32529,
in case that gets caught up in review or this limitation is accidentally
reintroduced I added 'Integration' to the name of the test, as well.

**Link to tracking Issue:**
#32532

**Testing:** Ran the test locally to confirm that the test runs
successfully.
@atoulme
Copy link
Contributor

atoulme commented Apr 19, 2024

@dehaansa fixed this with #32547

@atoulme atoulme closed this as completed Apr 19, 2024
@crobert-1
Copy link
Member Author

Thanks @dehaansa, appreciate the quick resolution here!

@crobert-1 crobert-1 mentioned this issue Apr 22, 2024
Closed
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
@dehaansa @rimitchell
[chore][CI/CD] Fix cloudflare receiver integration test (open-telemet…
9085ee3 
…ry#32547)

Fixed the expected file extension for golden metrics comparison in
cloudflare receiver integration test to be .yaml, not .json.

Due to the undocumented behavior of the Integration test Make tasks only
running tests containing the string 'Integration', this was broken when
golden metrics were changed in test from JSON to YAML in
open-telemetry#20438.


While the 'Integration' restriction is being addressed in
open-telemetry#32529,
in case that gets caught up in review or this limitation is accidentally
reintroduced I added 'Integration' to the name of the test, as well.

**Link to tracking Issue:**
open-telemetry#32532

**Testing:** Ran the test locally to confirm that the test runs
successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehaansa dehaansa

Labels
needs triage New item requiring triage receiver/cloudflare
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atoulme @dehaansa @crobert-1