Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report errors to log.Error channel in the spam exporter #32429

Closed
LukaszByczynski opened this issue Apr 16, 2024 · 3 comments
Closed

Report errors to log.Error channel in the spam exporter #32429

LukaszByczynski opened this issue Apr 16, 2024 · 3 comments

Comments

@LukaszByczynski
Copy link
Contributor

LukaszByczynski commented Apr 16, 2024

Component(s)

exporter/sapm

Describe the issue you're reporting

Currently, the spam exporter reports errors only to the debug channel. From an operational perspective, this setting is incorrect because if I want to monitor errors, I have to enable all debug logs, which is not my intention.

For instance, zipkin exporter logging errors to the correct log channel:

return fmt.Errorf("failed to push trace data via Zipkin exporter: %w", err)

@LukaszByczynski LukaszByczynski added the needs triage New item requiring triage label Apr 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Code owner approved PR resolving this issue, removing needs triage

codeboten pushed a commit that referenced this issue May 29, 2024
…onses. (#32430)

**Description:** Log level has been changed to Error from Debug for the
failed responses

**Link to tracking Issue:** #32429

**Testing:** Check log messages
@codeboten
Copy link
Contributor

Fixed by #32430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants