Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] staticcheck fails on deprecated grpc.DialContext #32297

Closed
songy23 opened this issue Apr 10, 2024 · 1 comment · Fixed by #32300
Closed

[chore] staticcheck fails on deprecated grpc.DialContext #32297

songy23 opened this issue Apr 10, 2024 · 1 comment · Fixed by #32300
Assignees
@crobert-1
Labels
cmd/telemetrygen telemetrygen command dependency issue

Comments

@songy23
Copy link
Member

songy23 commented Apr 10, 2024

Component(s)

cmd/telemetrygen

Describe the issue you're reporting

See an example in https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8628541634/job/23650975835?pr=32276#step:8:110

SA1019: grpc.DialContext is deprecated: use NewClient instead.  Will be supported throughout 1.x. (staticcheck)
@songy23 songy23 added needs triage New item requiring triage dependency issue labels Apr 10, 2024
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@songy23 songy23 mentioned this issue Apr 10, 2024
Merged
1 task
@crobert-1 crobert-1 mentioned this issue Apr 10, 2024
Merged
@crobert-1 crobert-1 self-assigned this Apr 10, 2024
@crobert-1 crobert-1 removed the needs triage New item requiring triage label Apr 10, 2024
codeboten pushed a commit that referenced this issue Apr 10, 2024
@crobert-1
[chore][cmd/telemetrygen] Fix deprecated method usage (#32300)
2b0d1be 
`grpc.DialContext` has been deprecated in favor of `grpc.NewClient`. The
only difference relevant to our usage is that the context is no longer
passed in. I investigated, and the context being cancelled and exiting
the running sub-goroutine is [handled
internally](https://github.com/grpc/grpc-go/blob/d32e66ce27447a0a217464a36fdd3935801c0453/clientconn.go#L135)
in an equivalent way to how we were using `grpc.DialContext`, so there
shouldn't be any impact here.

Resolves #32297
@songy23 songy23 mentioned this issue Apr 11, 2024
Merged
@github-actions github-actions bot mentioned this issue Apr 16, 2024
Closed
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
@crobert-1 @rimitchell
[chore][cmd/telemetrygen] Fix deprecated method usage (open-telemetry…
2e993a2 
…#32300)

`grpc.DialContext` has been deprecated in favor of `grpc.NewClient`. The
only difference relevant to our usage is that the context is no longer
passed in. I investigated, and the context being cancelled and exiting
the running sub-goroutine is [handled
internally](https://github.com/grpc/grpc-go/blob/d32e66ce27447a0a217464a36fdd3935801c0453/clientconn.go#L135)
in an equivalent way to how we were using `grpc.DialContext`, so there
shouldn't be any impact here.

Resolves open-telemetry#32297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crobert-1 crobert-1

Labels
cmd/telemetrygen telemetrygen command dependency issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore][cmd/telemetrygen] Fix deprecated method usage crobert-1/opentelemetry-collector-contrib
2 participants
@songy23 @crobert-1