Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

koanf parsing uses the same delimiter #31925

Closed
mike1997-code opened this issue Mar 25, 2024 · 3 comments · Fixed by #33214
Closed

koanf parsing uses the same delimiter #31925

mike1997-code opened this issue Mar 25, 2024 · 3 comments · Fixed by #33214
Assignees
@odubajDT
Labels
cmd/opampsupervisor enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest

Comments

@mike1997-code
Copy link

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

I found that in addition to the code here(url) using . as the delimiter, opampsupervisor and otel parsing configurations both use ::. Maybe it would be a better practice to use :: uniformly?
@mike1997-code mike1997-code added the needs triage New item requiring triage label Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot mentioned this issue Mar 26, 2024
Closed
This was referenced Apr 2, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue Apr 16, 2024
Closed
@evan-bradley
Copy link
Contributor

evan-bradley commented Apr 16, 2024 •
edited
Loading

I don't think this should matter too much considering it is only used for querying the config in the code (example), but I don't see any reason why we shouldn't align with the Collector here.

@evan-bradley evan-bradley added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers priority:p3 Lowest and removed needs triage New item requiring triage labels Apr 16, 2024
@odubajDT
Copy link
Contributor

Hi! I would like to start this issue! cc @evan-bradley

@odubajDT odubajDT mentioned this issue May 24, 2024
Merged
@evan-bradley evan-bradley removed the help wanted Extra attention is needed label May 24, 2024
evan-bradley pushed a commit that referenced this issue May 24, 2024
@odubajDT
fix: unify koanf delimiter to otel (#33214)
dc9818b 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:**
Fixes #31925

Signed-off-by: odubajDT <[email protected]>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jul 11, 2024
@odubajDT @cparkins
fix: unify koanf delimiter to otel (open-telemetry#33214)
4e9b049 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:**
Fixes open-telemetry#31925

Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odubajDT odubajDT

Labels
cmd/opampsupervisor enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unify koanf delimiter to otel odubajDT/opentelemetry-collector-contrib
3 participants
@evan-bradley @odubajDT @mike1997-code