Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ServiceAccount auth in kubeletstats receiver #311

Closed
pmcollins opened this issue Jun 11, 2020 · 1 comment
Closed

Add support for ServiceAccount auth in kubeletstats receiver #311

pmcollins opened this issue Jun 11, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pmcollins
Copy link
Member

The kubeletstats receiver only supports TLS auth at the moment.

@pmcollins
Copy link
Member Author

I have already coded this, but need to test more before submitting a PR. This can be assigned to me.

tigrannajaryan pushed a commit that referenced this issue Jun 17, 2020
Kubeletstats receiver only supported TLS auth. This change adds support
for ServiceAccount auth as well.

**Link to tracking Issue:** #311 

**Testing:** Manual testing of ServiceAccount auth was done in GKE.

**Documentation:** ServiceAccount config is already in the README.
wyTrivail referenced this issue in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
Kubeletstats receiver only supported TLS auth. This change adds support
for ServiceAccount auth as well.

**Link to tracking Issue:** #311 

**Testing:** Manual testing of ServiceAccount auth was done in GKE.

**Documentation:** ServiceAccount config is already in the README.
mxiamxia referenced this issue in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
* Add ability to exclude a set of spans from being processed.

* Specify include/exclude option

* Address first set of comments

* REVERT ME AFTER A BREAK

* Address comments

* Clarify exclusion language.
@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Merge propagation

Rename and merge propagation and api/propagation
to api/propagators.

Drop propagator suffix in general such that
TextFormatPropagator becomes TextFormat since
usage is propagators.TextFormat

fixes #311

* Rebase and godoc updates

* Revert go mod changes

* Replace carrier with supplier in godoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants