Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http semantic convention breaking changes in 1.23 #30935

Closed
wangzlei opened this issue Jan 31, 2024 · 3 comments
Closed

Http semantic convention breaking changes in 1.23 #30935

wangzlei opened this issue Jan 31, 2024 · 3 comments
Labels
bug Something isn't working closed as inactive needs triage New item requiring triage Stale

Comments

@wangzlei
Copy link
Contributor

wangzlei commented Jan 31, 2024

Component(s)

No response

What happened?

Description

http semantic convention 1.23.0 is declared as stable and introduces some attribute changes. For example, AttributeHTTPMethod is from http.method to http.request.method. Now most of language SDKs have moved to the latest http semantic convention and removed support environment variable OTEL_SEMCONV_STABILITY_OPT_IN.

Right now some vendors' exporter in Collector have translation logic like

import conventions "go.opentelemetry.io/collector/semconv/v1.6.1"

span.Attributes().Range(func(key string, value pcommon.Value) bool {
		switch key {
		case conventions.AttributeHTTPMethod:  // only handle http.method, cannot handle http.request.method
			translate to vendor's span format...

If we cannot control what version of OTel SDK user is using, how does Collector ensure both forward and backward compatibility?

Steps to Reproduce

Expected Result

OTel Collector can handle both old and new version of SDK.

Actual Result

Collector version

0.93.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@jsultana-leap
Copy link

jsultana-leap commented Feb 22, 2024

Thanks so much for the quick PR to address this :) Can I ask roughly when the fix will be released in a new version?

TylerHelmuth added a commit that referenced this issue Feb 27, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

`awsxrayexporter` is able to handle both old and new versions of http
span attributes, support translate new http attributes to xray segment
fields by following http [server
span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-server)
and [client
span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-client)
spec.

**Link to tracking Issue:** <Issue number if applicable>

#30935

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
https://opentelemetry.io/blog/2023/http-conventions-declared-stable/

---------

Co-authored-by: Tyler Helmuth <[email protected]>
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this issue Mar 13, 2024
…elemetry#31120)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

`awsxrayexporter` is able to handle both old and new versions of http
span attributes, support translate new http attributes to xray segment
fields by following http [server
span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-server)
and [client
span](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/http/http-spans.md#http-client)
spec.

**Link to tracking Issue:** <Issue number if applicable>

open-telemetry#30935

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
https://opentelemetry.io/blog/2023/http-conventions-declared-stable/

---------

Co-authored-by: Tyler Helmuth <[email protected]>
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed as inactive needs triage New item requiring triage Stale
Projects
None yet
Development

No branches or pull requests

2 participants