-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/stanza] Recombine operator inverts 'overwrite_with' setting #30783
Labels
bug
Something isn't working
Comments
djaglowski
added a commit
that referenced
this issue
Jan 25, 2024
Fixes #30783 --------- Co-authored-by: Yang Song <[email protected]>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this issue
Feb 1, 2024
…y#30786) Fixes open-telemetry#30783 --------- Co-authored-by: Yang Song <[email protected]>
anthoai97
pushed a commit
to anthoai97/opentelemetry-collector-contrib
that referenced
this issue
Feb 12, 2024
…y#30786) Fixes open-telemetry#30783 --------- Co-authored-by: Yang Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
pkg/stanza
What happened?
Description
When using the
overwrite_with
setting, the recombine operator should either choose the newest or oldest entry in a batch as the base. Currently, it is doing the opposite in each case.While this is clearly a bug fix, it may make sense to invert the default value as well, so that people currently using the operator without this setting do not experience a breaking change.
Collector version
v0.92.0
Environment information
No response
OpenTelemetry Collector configuration
No response
Log output
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: