Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datadog Receiver does not collect service.version #30526

Closed
backjo opened this issue Jan 13, 2024 · 2 comments · Fixed by #30225
Closed

Datadog Receiver does not collect service.version #30526

backjo opened this issue Jan 13, 2024 · 2 comments · Fixed by #30225
Labels
bug Something isn't working needs triage New item requiring triage receiver/datadog

Comments

@backjo
Copy link
Contributor

backjo commented Jan 13, 2024 •
edited
Loading

Component(s)

receiver/datadog

What happened?

Description

The Datadog Receiver does not pick up the service version correctly from Datadog spans.

Steps to Reproduce

Use dd-trace-dotnet with DD_VERSION set. Send trace spans to the DD receiver.

Expected Result

The DD receiver should collect service.version correctly.

Actual Result

The DD receiver does not pickup the service version from the datadog spans.

Collector version

v0.92.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@backjo backjo added bug Something isn't working needs triage New item requiring triage labels Jan 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@backjo backjo mentioned this issue Jan 13, 2024
Merged
@github-actions github-actions bot mentioned this issue Jan 16, 2024
Closed
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
@jpkrohling
Copy link
Member

@boostchicken, are you interested in picking this up?

@github-actions github-actions bot mentioned this issue Jan 30, 2024
Closed
jpkrohling pushed a commit that referenced this issue Feb 1, 2024
@backjo
fix(datadogreceiver): set AppVersion on payload so it propagates corr…
344a0d2 
…ectly (#30225)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR sets the AppVersion property for the default fallthrough case if
it exists on any spans in the request. This allows it to properly
propagate through to Datadog. Currently, if using a library such as
datadog/dd-trace-dotnet , the datadog service version property
(dd_version) does not propagate through to datadog at all.

The bug that this fixes is that the Datadog version resource attribute
is currently not flowing through.
**Link to tracking Issue:** <Issue number if applicable>
Closes #30526 

**Testing:** <Describe what testing was performed and which tests were
added.>
Local testing using delve to confirm expected behavior, added existing
version tag to tests. Deployed patch internally on OpenTelemetry
collector and observed desired behavior.
**Documentation:** <Describe the documentation added.>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
@backjo @cparkins
fix(datadogreceiver): set AppVersion on payload so it propagates corr…
6ea8c6a 
…ectly (open-telemetry#30225)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR sets the AppVersion property for the default fallthrough case if
it exists on any spans in the request. This allows it to properly
propagate through to Datadog. Currently, if using a library such as
datadog/dd-trace-dotnet , the datadog service version property
(dd_version) does not propagate through to datadog at all.

The bug that this fixes is that the Datadog version resource attribute
is currently not flowing through.
**Link to tracking Issue:** <Issue number if applicable>
Closes open-telemetry#30526 

**Testing:** <Describe what testing was performed and which tests were
added.>
Local testing using delve to confirm expected behavior, added existing
version tag to tests. Deployed patch internally on OpenTelemetry
collector and observed desired behavior.
**Documentation:** <Describe the documentation added.>
anthoai97 pushed a commit to anthoai97/opentelemetry-collector-contrib that referenced this issue Feb 12, 2024
@backjo @anthoai97
fix(datadogreceiver): set AppVersion on payload so it propagates corr…
bed4c8e 
…ectly (open-telemetry#30225)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR sets the AppVersion property for the default fallthrough case if
it exists on any spans in the request. This allows it to properly
propagate through to Datadog. Currently, if using a library such as
datadog/dd-trace-dotnet , the datadog service version property
(dd_version) does not propagate through to datadog at all.

The bug that this fixes is that the Datadog version resource attribute
is currently not flowing through.
**Link to tracking Issue:** <Issue number if applicable>
Closes open-telemetry#30526 

**Testing:** <Describe what testing was performed and which tests were
added.>
Local testing using delve to confirm expected behavior, added existing
version tag to tests. Deployed patch internally on OpenTelemetry
collector and observed desired behavior.
**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage New item requiring triage receiver/datadog
Projects
None yet
Milestone
No milestone
2 participants
@jpkrohling @backjo