Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit documentation #30166

Closed
hughesjj opened this issue Dec 21, 2023 · 5 comments
Closed

Revisit documentation #30166

hughesjj opened this issue Dec 21, 2023 · 5 comments
Labels
closed as inactive documentation Improvements or additions to documentation Stale

Comments

@hughesjj
Copy link
Contributor

Component(s)

No response

Describe the issue you're reporting

Imo CONTRIBUTING.md is getting a bit big. I saw that the upstream opentelemetry-collector has a docs folder and was wondering about possibly doing similar on our side.

I wanted to document some things around running integration tests and build constraints that I didn't see elsewhere. I can instead make a PR against CONTRIBUTING.md if that's preferable.

I'll also note that some opentelemetry-collector-contrib specific documentation lives in opentelemetry-collector (ex stuff around mdatagen). While I'd love to see mdatagen upstreamed, I'm of the opinion said docs would better live here (maybe with a link from upstream ?) until we merge it upstream.

Lastly, I'd like to reuse these markdown files for the opentelemetry.io site if possible, but that's for the future.

In general I want to connect with other people in the collector-contrib and collector spaces to improve documentation, and intend to use this as a centralized place to discuss such unless/until we get more inertia and consensus around documentation improvements..

@hughesjj hughesjj added the needs triage New item requiring triage label Dec 21, 2023
@crobert-1 crobert-1 added the documentation Improvements or additions to documentation label Dec 22, 2023
@crobert-1
Copy link
Member

Any documentation PRs are welcome! To make it easiest on reviewers, please keep content and re-organization changes as distinct as possible. It's a lot easier to review if you know it's just content being moved vs. moved and modified. Sometimes it's impossible to separate, but just a thought.

Some kind of landing page would be helpful to direct users to whatever information they're looking for. Obviously one big document is hard to process, but it at least allows one central search of contents, so we want to make sure we don't make it harder to find what someone's looking for by breaking it up into different files.

Specifics can probably be discussed in PRs.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Dec 22, 2023
@hughesjj
Copy link
Contributor Author

hughesjj commented Dec 22, 2023

We could get started with this docs PR for some testing guidance

I could see such being relevant to discussion in ex this PR

bogdandrutu pushed a commit that referenced this issue Jan 10, 2024
**Description:** Adds some documentation around test targets to a new
(to this project) `docs` folder, similar to what we have in
`opentelemetry-collector` (upstream)

**Link to tracking Issue:**
[`30166`](#30166)

**Testing:** N/A

**Documentation:** Adds documentation to `docs` folder but not linked to
`CONTRIBUTORS.md` until we get some discussion rolling about how to
potentially reorganize such

---------

Co-authored-by: bryan-aguilar <[email protected]>
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this issue Jan 10, 2024
…emetry#30172)

**Description:** Adds some documentation around test targets to a new
(to this project) `docs` folder, similar to what we have in
`opentelemetry-collector` (upstream)

**Link to tracking Issue:**
[`30166`](open-telemetry#30166)

**Testing:** N/A

**Documentation:** Adds documentation to `docs` folder but not linked to
`CONTRIBUTORS.md` until we get some discussion rolling about how to
potentially reorganize such

---------

Co-authored-by: bryan-aguilar <[email protected]>
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Feb 20, 2024
@crobert-1 crobert-1 removed the Stale label Feb 26, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 29, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive documentation Improvements or additions to documentation Stale
Projects
None yet
Development

No branches or pull requests

2 participants