Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/resourcedetection] eks detector does not check if it's running on AWS #2977

Closed
jrcamp opened this issue Apr 1, 2021 · 4 comments
Closed

[processor/resourcedetection] eks detector does not check if it's running on AWS #2977

jrcamp opened this issue Apr 1, 2021 · 4 comments
Labels
bug Something isn't working comp:aws AWS components processor/resourcedetection Resource detection processor

Comments

@jrcamp
Copy link
Contributor

jrcamp commented Apr 1, 2021

The eks detector in resourcedetection only checks if it's on k8s and does not verify that it is on AWS.
@jrcamp jrcamp added the bug Something isn't working label Apr 1, 2021
@jrcamp jrcamp self-assigned this Apr 1, 2021
@jrcamp jrcamp removed their assignment Jun 22, 2021
punya pushed a commit to punya/opentelemetry-collector-contrib that referenced this issue Jul 21, 2021
@sincejune
Rename marshall to marshal in all the occurrences (open-telemetry…
d85f6cd 
…#2977)

* Rename marshall to marshal in all the occurrences

* rename missing file

* update changelog
alexperez52 referenced this issue in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
@sincejune
Rename marshall to marshal in all the occurrences (#2977)
6661f03 
* Rename marshall to marshal in all the occurrences

* rename missing file

* update changelog
@alolita alolita added the comp:aws AWS components label Sep 2, 2021
@alolita
Copy link
Member

alolita commented Jan 10, 2022

@aateeqi can you take a look at this issue?

@alolita alolita added the processor/resourcedetection Resource detection processor label Jan 10, 2022
@aateeqi
Copy link
Contributor

aateeqi commented Jan 12, 2022

@alolita At this stage, this might not be able to be done and we may have to rely on our current check.

My original idea was to use instance metadata to detect if we're running on AWS but this may not be possible since metadata is not available in fargate.

In the current state, we assume that the customer only include eks in their config if their running on AWS which may be a fair assumption.

@sethAmazon
Copy link
Contributor

Can you please give us your config please. As well as output.

@aateeqi aateeqi mentioned this issue Jan 17, 2022
Merged
@jefchien
Copy link
Contributor

@aateeqi Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working comp:aws AWS components processor/resourcedetection Resource detection processor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jrcamp @Aneurysm9 @alolita @aateeqi @sethAmazon @jefchien