Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review usage of foresight #19932

Closed
codeboten opened this issue Mar 20, 2023 · 4 comments · Fixed by #20668
Closed

Review usage of foresight #19932

codeboten opened this issue Mar 20, 2023 · 4 comments · Fixed by #20668
Labels
ci-cd CI, CD, testing, build issues

Comments

@codeboten
Copy link
Contributor

Component(s)

No response

Describe the issue you're reporting

We've been sending data to foresight for some time now, and it's unclear to me whether we're using the tool at all. I've only logged into foresight a handful of times and did not immediately get anything from using the tool I wasn't already getting through github action logs.

I'm opening this issue to capture a discussion on whether we should discontinue the use of the tool and simplify the build pipeline. One of the downsides currently is that foresight immediately comments on new PRs, making it somewhat harder to identify PRs that have not been reviewed at all.

@codeboten codeboten added the ci-cd CI, CD, testing, build issues label Mar 20, 2023
@TylerHelmuth
Copy link
Member

I have tried to use it a couple times but find myself going back to GitHub action logs directly.

@serkan-ozal
Copy link

Hi @codeboten @TylerHelmuth,

This is Serkan, co-founder and CTO of Thundra, which is the company behind Foresight.

We would like to schedule a quick meeting to get your feedbacks and present a demo about how you can use Foresight to monitor flaky tests and CI pipelines.

Other than that, do you see any missing feature or issues with the Foresight?

@codeboten
Copy link
Contributor Author

Hi @serkan-ozal, at this point, I just don't use the tool or have a need that isn't already solved by what I'm getting from github actions. Data has been sent to foresight for some time now, and I've yet to find myself in a scenario where i've needed to go to foresight to troubleshoot the issue.

Unfortunately, I only have so much time in a day, and spending it to learn another tool isn't something I have time for.

Again though, if other contributors/maintainers feel differently, I'm not opposed to keeping it. I just don't want to have this additional configuration in the repo if no one is making use of it.

codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Apr 4, 2023
jpkrohling pushed a commit that referenced this issue Apr 5, 2023
* [chore] remove use of foresight

Fixes #19932

Signed-off-by: Alex Boten <[email protected]>

* tee results to testoutput

Signed-off-by: Alex Boten <[email protected]>

---------

Signed-off-by: Alex Boten <[email protected]>
@dmitryax
Copy link
Member

dmitryax commented Apr 5, 2023

@serkan-ozal, looks like the main use case for foresight is to highlight the tests run time and flakiness. It's a valid use case, but based on our experience, it didn't provide enough value to justify the added complexity.

We are looking for a solution to another important use case described in #20718. Essentially, we want to be able to send the performance test results somewhere where we can see the data on charts and be able to fetch them programmatically.

Do you think foresight can help with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants