[extension/storage/dbstorage] Flaky Test

[djaglowski]

Observed here: https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/7009845542?check_suite_focus=true#step:7:1415

sqlite3-binding.c: In function 'sqlite3SelectNew':
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~
==3180==ERROR: ThreadSanitizer failed to allocate 0x0000026e9000 (40800256) bytes at 0x200d935630000 (error code: 87)
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/dbstorage	0.072s

[djaglowski]

cc code owners @dmitryax @atoulme

[dmitryax]

Yes, I also stumbled into it. looking

[atoulme]

I did too. I could not make sense of that failure. Good luck Dmitrii.

[dmitryax]

Got another occurence https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/3379452850/jobs/5611039833.

Looks like another module got stanza dependancy. Re-running it for now

[atoulme]

The warnings seem to be related to mattn/go-sqlite3#803

[atoulme]

@dmitryax the run you reference shows this error:

    rotation_test.go:295: 
        	Error Trace:	D:\a\opentelemetry-collector-contrib\opentelemetry-collector-contrib\pkg\stanza\operator\input\file\rotation_test.go:295
        	Error:      	elements differ
        	            	
        	            	extra elements in list B:
        	            	([]interface {}) (len=1) {
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  12"
        	            	}
        	            	
        	            	
        	            	listA:
        	            	([]string) (len=20) {
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   0",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   1",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   2",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   3",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   4",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   5",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   6",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   7",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   8",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   9",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  10",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  11",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  12",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  13",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  14",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  15",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  16",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  17",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  18",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  19"
        	            	}
        	            	
        	            	
        	            	listB:
        	            	([]string) (len=21) {
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   0",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   1",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  12",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  10",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  11",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  12",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  13",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   2",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   3",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   4",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   5",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   6",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   7",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   8",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco   9",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  14",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  15",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  16",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  17",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  18",
        	            	 (string) (len=50) "otafethsbzrjxawnwekrbemfdzdcekxbakjqzlcttmttco  19"
        	            	}
        	Test:       	TestRotation/NoDeletion/CopyTruncateTimestamped

Is that correct? It doesn't seem this like this failure is related to dbstorage. What am I missing?

[dmitryax]

No, the error is the same as posted here initially

FAIL
mingw32-make[2]: *** [../../Makefile.Common:57: test] Error 1
mingw32-make[2]: Leaving directory 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza'
mingw32-make[1]: *** [makefile:188: pkg/stanza] Error 2
mingw32-make[1]: *** Waiting for unfinished jobs....
# github.com/mattn/go-sqlite3
sqlite3-binding.c: In function 'sqlite3SelectNew':
sqlite3-binding.c:128049:10: warning: function may return address of local variable [-Wreturn-local-addr]
128049 |   return pNew;
       |          ^~~~
sqlite3-binding.c:128009:10: note: declared here
128009 |   Select standin;
       |          ^~~~~~~
?   	github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema/docsgen	[no test files]
?   	github.com/open-telemetry/opentelemetry-collector-contrib/cmd/configschema/docsgen/docsgen	[no test files]
mingw32-make[2]: Leaving directory 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/configschema'
mingw32-make[1]: Leaving directory 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
mingw32-make: *** [makefile:95: gotest] Error 2
Error: Process completed with exit code 1.

[dmitryax]

Actually you're right. I got confused by the warnings. Sorry. I'll need to create another issue

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[atoulme]

These warnings are annoying. Do we want them fixed as part of this issue? Close and open a new one? It appears this issue is no longer occurring.

[djaglowski]

@atoulme, a clean issue sounds reasonable to me.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

[atoulme]

I had followed up with #19152, and am not sure we still see those warnings since I updated the version. I'll take a look.

[atoulme]

I don't see warnings again, and the failure doesn't occur anymore. Good to close this.