add tests

exporter/datadogexporter/factory_test.go

@@ -70,8 +70,9 @@ func TestCreateDefaultConfig(t *testing.T) {
  QueueSettings: exporterhelper.NewDefaultQueueSettings(),
 
  API: ddconfig.APIConfig{
- Key: "API_KEY",
- Site: "SITE",
+ Key: "API_KEY",
+ Site: "SITE",
+ FailOnInvalidKey: false,
  },
 
  Metrics: ddconfig.MetricsConfig{
@@ -151,8 +152,9 @@ func TestLoadConfig(t *testing.T) {
  Tags: []string{"example:tag"},
  }, apiConfig.TagsConfig)
  assert.Equal(t, ddconfig.APIConfig{
- Key: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
- Site: "datadoghq.eu",
+ Key: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+ Site: "datadoghq.eu",
+ FailOnInvalidKey: true,
  }, apiConfig.API)
  assert.Equal(t, ddconfig.MetricsConfig{
  TCPAddr: confignet.TCPAddr{
@@ -202,8 +204,9 @@ func TestLoadConfig(t *testing.T) {
  },
 
  API: ddconfig.APIConfig{
- Key: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
- Site: "datadoghq.com",
+ Key: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+ Site: "datadoghq.com",
+ FailOnInvalidKey: false,
  },
 
  Metrics: ddconfig.MetricsConfig{
@@ -303,8 +306,9 @@ func TestLoadConfigEnvVariables(t *testing.T) {
  }, apiConfig.TagsConfig)
  assert.Equal(t,
  ddconfig.APIConfig{
- Key: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
- Site: "datadoghq.eu",
+ Key: "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
+ Site: "datadoghq.eu",
+ FailOnInvalidKey: false,
  }, apiConfig.API)
  assert.Equal(t,
  ddconfig.MetricsConfig{
@@ -357,8 +361,9 @@ func TestLoadConfigEnvVariables(t *testing.T) {
  EnvVarTags: "envexample:tag envexample2:tag",
  }, defaultConfig.TagsConfig)
  assert.Equal(t, ddconfig.APIConfig{
- Key: "replacedapikey",
- Site: "datadoghq.test",
+ Key: "replacedapikey",
+ Site: "datadoghq.test",
+ FailOnInvalidKey: false,
  }, defaultConfig.API)
  assert.Equal(t, ddconfig.MetricsConfig{
  TCPAddr: confignet.TCPAddr{
@@ -417,6 +422,49 @@ func TestCreateAPIMetricsExporter(t *testing.T) {
  assert.NotNil(t, exp)
 }
 
+func TestCreateAPIMetricsExporterFailOnInvalidkey(t *testing.T) {
+ server := testutils.DatadogServerMock(testutils.ValidateAPIKeyEndpointInvalid)
+ defer server.Close()
+
+ factories, err := componenttest.NopFactories()
+ require.NoError(t, err)
+
+ factory := NewFactory()
+ factories.Exporters[typeStr] = factory
+ cfg, err := servicetest.LoadConfigAndValidate(filepath.Join("testdata", "config.yaml"), factories)
+
+ require.NoError(t, err)
+ require.NotNil(t, cfg)
+
+ // Use the mock server for API key validation
+ c := (cfg.Exporters[config.NewComponentIDWithName(typeStr, "api")]).(*ddconfig.Config)
+ c.Metrics.TCPAddr.Endpoint = server.URL
+ c.HostMetadata.Enabled = false
+
+ t.Run("failed_on_invalid_key is true", func(t *testing.T) {
+ c.API.FailOnInvalidKey = true
+ ctx := context.Background()
+ exp, err := factory.CreateMetricsExporter(
+ ctx,
+ componenttest.NewNopExporterCreateSettings(),
+ cfg.Exporters[config.NewComponentIDWithName(typeStr, "api")],
+ )
+ assert.EqualError(t, err, "API Key validation failed")
+ assert.Nil(t, exp)
+ })
+ t.Run("failed_on_invalid_key is false", func(t *testing.T) {
+ c.API.FailOnInvalidKey = false
+ ctx := context.Background()
+ exp, err := factory.CreateMetricsExporter(
+ ctx,
+ componenttest.NewNopExporterCreateSettings(),
+ cfg.Exporters[config.NewComponentIDWithName(typeStr, "api")],
+ )
+ assert.Nil(t, err)
+ assert.NotNil(t, exp)
+ })
+}
+
 func TestCreateAPITracesExporter(t *testing.T) {
  server := testutils.DatadogServerMock()
  defer server.Close()
@@ -447,6 +495,49 @@ func TestCreateAPITracesExporter(t *testing.T) {
  assert.NotNil(t, exp)
 }
 
+func TestCreateAPITracesExporterFailOnInvalidkey(t *testing.T) {
+ server := testutils.DatadogServerMock(testutils.ValidateAPIKeyEndpointInvalid)
+ defer server.Close()
+
+ factories, err := componenttest.NopFactories()
+ require.NoError(t, err)
+
+ factory := NewFactory()
+ factories.Exporters[typeStr] = factory
+ cfg, err := servicetest.LoadConfigAndValidate(filepath.Join("testdata", "config.yaml"), factories)
+
+ require.NoError(t, err)
+ require.NotNil(t, cfg)
+
+ // Use the mock server for API key validation
+ c := (cfg.Exporters[config.NewComponentIDWithName(typeStr, "api")]).(*ddconfig.Config)
+ c.Metrics.TCPAddr.Endpoint = server.URL
+ c.HostMetadata.Enabled = false
+
+ t.Run("failed_on_invalid_key is true", func(t *testing.T) {
+ c.API.FailOnInvalidKey = true
+ ctx := context.Background()
+ exp, err := factory.CreateTracesExporter(
+ ctx,
+ componenttest.NewNopExporterCreateSettings(),
+ cfg.Exporters[config.NewComponentIDWithName(typeStr, "api")],
+ )
+ assert.EqualError(t, err, "API Key validation failed")
+ assert.Nil(t, exp)
+ })
+ t.Run("failed_on_invalid_key is false", func(t *testing.T) {
+ c.API.FailOnInvalidKey = false
+ ctx := context.Background()
+ exp, err := factory.CreateTracesExporter(
+ ctx,
+ componenttest.NewNopExporterCreateSettings(),
+ cfg.Exporters[config.NewComponentIDWithName(typeStr, "api")],
+ )
+ assert.Nil(t, err)
+ assert.NotNil(t, exp)
+ })
+}
+
 func TestOnlyMetadata(t *testing.T) {
  server := testutils.DatadogServerMock()
  defer server.Close()

exporter/datadogexporter/internal/testutils/test_utils.go

@@ -39,22 +39,40 @@ type DatadogServer struct {
 }
 
 // DatadogServerMock mocks a Datadog backend server
-func DatadogServerMock() *DatadogServer {
+func DatadogServerMock(overwriteHandlerFuncs ...OverwriteHandleFunc) *DatadogServer {
  metadataChan := make(chan []byte)
- handler := http.NewServeMux()
- handler.HandleFunc("/api/v1/validate", validateAPIKeyEndpoint)
- handler.HandleFunc("/api/v1/series", metricsEndpoint)
- handler.HandleFunc("/intake", newMetadataEndpoint(metadataChan))
- handler.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {})
+ mux := http.NewServeMux()
 
- srv := httptest.NewServer(handler)
+ handlers := map[string]http.HandlerFunc{
+ "/api/v1/validate": validateAPIKeyEndpoint,
+ "/api/v1/series": metricsEndpoint,
+ "/intake": newMetadataEndpoint(metadataChan),
+ "/": func(w http.ResponseWriter, r *http.Request) {},
+ }
+ for _, f := range overwriteHandlerFuncs {
+ p, hf := f()
+ handlers[p] = hf
+ }
+ for pattern, handler := range handlers {
+ mux.HandleFunc(pattern, handler)
+ }
+
+ srv := httptest.NewServer(mux)
 
  return &DatadogServer{
  srv,
  metadataChan,
  }
 }
 
+// OverwriteHandleFuncs allows to overwrite the default handler functions
+type OverwriteHandleFunc func() (string, http.HandlerFunc)
+
+// ValidateAPIKeyEndpointInvalid returns a handler function that returns an invalid API key response
+func ValidateAPIKeyEndpointInvalid() (string, http.HandlerFunc) {
+ return "/api/v1/validate", validateAPIKeyEndpointInvalid
+}
+
 type validateAPIKeyResponse struct {
  Valid bool `json:"valid"`
 }
@@ -67,6 +85,14 @@ func validateAPIKeyEndpoint(w http.ResponseWriter, r *http.Request) {
  w.Write(resJSON)
 }
 
+func validateAPIKeyEndpointInvalid(w http.ResponseWriter, r *http.Request) {
+ res := validateAPIKeyResponse{Valid: false}
+ resJSON, _ := json.Marshal(res)
+
+ w.Header().Set("Content-Type", "application/json")
+ w.Write(resJSON)
+}
+
 type metricsResponse struct {
  Status string `json:"status"`
 }

exporter/datadogexporter/testdata/config.yaml

@@ -21,6 +21,7 @@ exporters:
  api:
  key: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
  site: datadoghq.eu
+ fail_on_invalid_key: true
 
  traces:
  sample_rate: 1
@@ -63,7 +64,7 @@ exporters:
  datadog/invalid:
  metrics:
  endpoint: "invalid:"
- 
+
  traces:
  endpoint: "invalid:"