Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for compile issue #659 #660

Merged
merged 2 commits into from
Sep 5, 2017
Merged

Hotfix for compile issue #659 #660

merged 2 commits into from
Sep 5, 2017

Conversation

SloCompTech
Copy link
Contributor

@SloCompTech SloCompTech commented Sep 2, 2017

Fix for compile issue when compile there were error in config.h and value.h in pre-processing code, details in issue #659.

@SloCompTech
Copy link
Contributor Author

I also fixed instructions for install where parameters were switched

@cdunn2001
Copy link
Contributor

  • The README fix is good.
  • The C++11 setting is fine. I'm not sure it's needed, but we don't want to support non-C++11 anyway.
  • I'm not sure about the JSONCPP_USING_SECURE_MEMORY change. Someone might be relying on 0 as false. Note that version.h sets that to 0 if it was not defined, which is the proper logic.

Maybe there is a different problem with the Meson build, where version.h is somehow dropped?

@SloCompTech
Copy link
Contributor Author

SloCompTech commented Sep 4, 2017

Fixed readme, temporary fixed compile bug with adding jsoncpp_cdata.set('JSONCPP_USE_SECURE_MEMORY',0) in meson build config, that means that use of secure memory is disabled, but if you compile any program with -ljsoncpp it works, but if you enable USE_SECURE_MEMORY, then you get error on asString() method (when I compile my program)

ConfigModule.cpp:252:54: error: conversion from ‘std::__cxx11::basic_string<char, std::char_traits<char>, Json::SecureAllocator<char> >’ to non-scalar type ‘std::__cxx11::string {aka std::__cxx11::basic_string<char>}’ requested
           std::string text = entry[OPT_TYPE].asString();

This is defenetly compile issue.

@cdunn2001
Copy link
Contributor

@cdunn2001 cdunn2001 merged commit adb9ab1 into open-source-parsers:master Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants