Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: remove ccache micro management #1448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CMake: remove ccache micro management #1448

wants to merge 1 commit into from
+0 −10

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Nov 23, 2022

closes #1447

BillyDonahue
BillyDonahue approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@BillyDonahue BillyDonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change makes sense.
We're pretty laissez-faire with CMakeLists.txt changes.
As long as it doesn't break anything.

juan-lunarg
juan-lunarg reviewed Nov 13, 2023
View reviewed changes
Copy link

@juan-lunarg juan-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this as well building the Vulkan SDK and would like to see this merged.

@dlarsson-adobe
Copy link

I would love to see this merged too. Or at least put in some kind of check for whether it's the top level project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-lunarg juan-lunarg juan-lunarg left review comments

@BillyDonahue BillyDonahue BillyDonahue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake: remove ccache babysitting
4 participants
@SpaceIm @dlarsson-adobe @BillyDonahue @juan-lunarg