Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect btn #364

Open
wants to merge 2,728 commits into
base: dev
Choose a base branch
from
Open

Inspect btn #364

wants to merge 2,728 commits into from

Conversation

sarhiri
Copy link
Contributor

@sarhiri sarhiri commented May 9, 2024

References issue #. Please review this @teammember1, @teamMember2.

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would cause existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Inspect button functionality has deep rooted issue that we were unable to debug.

Approach

  • Removed button functionality for grabbing data with commentary.

seantokuzo and others added 30 commits December 19, 2023 18:19
build out login page - client
incorporate customFetch - get current user
Fix bug with setting test cookie in tests
fix double res.send in get current user route
Add Event Types to common pkg - update common pkg version in each service
common pkg update in each service
update common pkg in all services
update user_created event to enforce payload type
mdtagg and others added 29 commits May 1, 2024 14:06
Clicking example now populates cards that are not wrapped in
a link component. This allows the app to work the traditional
way and with our example button. useNavigate hook was used in
appplication card component to facilitate. Users can now also
click exit example button to reset all states and use the app
the traditional way.
Inside of application context add app was adjusted to
render multiple cards at once. Each cards data is added
to an object that is iterated over
Applications are now filtered inside of mapping function
Cards are now deleted without the ref hook
I believe the delRef hook was being used to
prevent an issue with event bubbling. Becuase
the delete button is nested inside of the
Card component and card has an onClick the
prior teams were calling the onClick on the
card as well as the delete button.
event.stopPropagation was used to prevent
the bubbling the del ref hook is now able
to be removed
@mdtagg mdtagg deleted the inspect-btn branch May 15, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants