-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Runtimes V3 #136
Merged
Open Runtimes V3 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
eldadfux
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Meldiron great stuff! This is a game changing PR!
eldadfux
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Runtimes V3 ⚡
Description
open-runtimes
, verbose should beOpen Runtimes
, and there is no shorthand (noopr
).openruntimes
should not be used.req
andres
params removed,context
introducedcontext.req
contains all information about http requestcontext.res
lets you configure all information about http requestres.json()
is nowcontext.res.json()
. same forres.send()
->context.res.send()
. New ones introduced.empty()
and.redirect()
context.log()
andcontext.error()
lets you reliably log. Native support (likeconsole.log
in Node) was removedreq.variables
removed, system variables should be used instead (in Node,process.env.MY_VAR
)req.payload
renamed tocontext.req.body
. Body is automatically parsed now to JSON if there is JSON content-type header. In future we plan to support more types such as XML, URL-encoded or Form Data bodies.res.json()
, now we doreturn context.res.json()
x-internal-challenge
tox-open-runtimes-secret
INTERNAL_RUNTIME_KEY
andINTERNAL_RUNTIME_ENTRYPOINT
toOPEN_RUNTIMES_SECRET
andOPEN_RUNTIMES_ENTRYPOINT
Development
Runtimes:
Other:
Tests coverage:
x-openruntimes-
onesDocs:
Post-release: